include node condition value in check message #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2362 +/- ##
==========================================
+ Coverage 80% 82.71% +2.7%
==========================================
Files 210 4 -206
Lines 14447 376 -14071
Branches 1561 72 -1489
==========================================
- Hits 11559 311 -11248
+ Misses 2488 44 -2444
+ Partials 400 21 -379 |
xvello
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provide additional information in service check message when the node condition check is failing.
Motivation
I was looking at the data we have for a failing kubernetes_state.node.ready service check and it says this:
node:xxx-0000 is currently reporting condition:ReadyThe condition is always present, but the value of the condition is the important bit. We should include that in the message.
This PR should change the message to be:
node:xxx-0000 is currently reporting condition:Ready = falseReview checklist
no-changeloglabel attached